voceconnect / cms-press

WordPress Plugin
15 stars 2 forks source link

usage of empty() and added capability_type field #43

Closed jimisaacs closed 14 years ago

jimisaacs commented 14 years ago

I noticed your usage of empty() in one area, but there may be more that I didn't see. empty() is not reliable when you intend to pass booleans values.

I have updates, but not familiar enough with Git.

If you want them, then please provide me with a means of just sending them to you.

Thank you

prettyboymp commented 14 years ago

Thanks for the feedback. I got your message with the changeset. I'll look through them and get them included in the next commit.

jimisaacs commented 14 years ago

Yeah, sorry about all those edits, I was assuming GitHub might automatically do something with the source code, it didn't so I just took it out.

prettyboymp commented 14 years ago

fixed in latest. Thanks again.

jimisaacs commented 14 years ago

no no, thank you, for a great start on something I'm sure will be very useful to a lot of people. When I get some time, I'll see what I can do with it here and there to help you get to a full release.