voceconnect / grunt-composer

A grunt wrapper for composer
17 stars 5 forks source link

Use child_process.exec and fixes some warnings #4

Closed LeoColomb closed 10 years ago

LeoColomb commented 10 years ago

Also fixes #1, fixes #3 in a better way.

prettyboymp commented 10 years ago

The issue with switching to child_process.exec is that composer commands with a lot of output could overflow the buffer, killing the process.

LeoColomb commented 10 years ago

Hmm, I also use grunt-php-cs-fixer with a task which generate about 500 lines, not a problem.

LeoColomb commented 10 years ago

Also, see my last commit.

prettyboymp commented 10 years ago

I'd still prefer the stream output to be live, but I don't know of a better solution right now.