voceconnect / grunt-composer

A grunt wrapper for composer
17 stars 5 forks source link

Composer Location, exec with php, and phpArgs #7

Closed benjdlambert closed 10 years ago

benjdlambert commented 10 years ago

I've added the ability to add a composer location, execute with php binary, and also the option to pass arguments to the php binary if using php.

I've added a load of unit tests too, and restructured how the shell command is built.

-B

benjdlambert commented 10 years ago

Oh, and this will also fix #6

jeffstieler commented 10 years ago

@benjdlambert am I missing something testing this?

Travis-CI reports a successful build, but I'm getting the following error: Warning: Cannot find module 'shelljs/global' Use --force to continue.

I had to add shelljs as a dev dependency in grunt-composer's package.json to fix locally.

benjdlambert commented 10 years ago

@jeffstieler You'd be correct, It seems I left out the dependency and it's missing an integration test. Let me fix this.

benjdlambert commented 10 years ago

@jeffstieler I've updated it, and it's got an integration test now, which runs part of npm test. With a sample composer.json in test/integration.

seanosh commented 10 years ago

@prettyboymp - going to kick this over to you since @jeffstieler is out of pocket...

prettyboymp commented 10 years ago

there is a chance that @jeffstieler is back before I get enough time to look at this. I like it off hand, but don't have enough time to be thorough with it at the moment.

benjdlambert commented 10 years ago

@prettyboymp @jeffstieler @prettyboymp no probs, sorry for the massive pull request, maybe should have split it out.. haha

cardip01 commented 10 years ago

:+1:

benjdlambert commented 10 years ago

Any news on this guys?

prettyboymp commented 10 years ago

I'm going to go ahead and merge this. I haven't been able to review it as much as I hoped, but there is no reason for our workload right now to hold this up any longer.

benjdlambert commented 10 years ago

Thanks for this guys. Awesome.