search

voceconnect / grunt-composer

A grunt wrapper for composer
17 stars 5 forks source link

Fixed error handling #9

Closed joerx closed 10 years ago

joerx commented 10 years ago

Handling only error code 127 and ignoring anything else seems a bit careless to me, and a bit of wasted effort - what does Grunts 'done' callback take an error argument for anyway? What if composer cowardly refuses to install my dependencies? It's silently failing and I get unrelated errors much later in the build...

Fixed that - just pass on the error, fail the build and let the user sort out whatever Composer is complaining about.

joerx commented 10 years ago

Anybody still maintaining this?

benjdlambert commented 10 years ago

Yeah there is, they're about, just pretty busy.

LeoColomb commented 10 years ago

This PR seems no more relevant...

joerx commented 10 years ago

yeah, looks like it.