Restructured grid Sass.

voceconnect / lift-search

Lift Search for WordPress

14 stars 12 forks source link

Restructured grid Sass. #27

Closed rglazebrook closed 11 years ago

rglazebrook commented 11 years ago

Changed grid Sass so we're being more specific about what classes get treated as columns. This is in reference to this bug: https://basecamp.com/2027151/projects/2023013-tribune-phase-2/todos/39916358-css-broke-on-add

jeffstieler commented 11 years ago

Just wanted to give this a +1: looks good to me.

Testing Note: the style conflict between post-selection-ui and Lift only occurs if Lift hasn't been configured and the banner is showing.

banderon commented 11 years ago

@jeffstieler What page are you seeing the style conflict on? Or is that the very bug this fixes?

jeffstieler commented 11 years ago

@banderon if Lift isn't configured, there will be a style conflict with anything using the post-selection-ui plugin. So sites where we are using Objects to Objects to connect post type for example.

chrisscott commented 11 years ago

@banderon tested on unconfigured lift and all looks good.

:tractor: :clock1: