search

voceconnect / multi-post-thumbnails

Adds multiple post thumbnails to a post type. If you've ever wanted more than one Featured Image on a post, this plugin is for you.
143 stars 63 forks source link

WordPress 3.5 file_frame Modal Boxes Stacking #10

Closed ajgagnon closed 11 years ago

ajgagnon commented 11 years ago

Thanks for the awesome plugin! I've gotten a change to test the version 1.5 and 1.6 with the new modal boxes on WordPress 3.5.1. I've noticed a strange bug with modal boxes stacking on top of eachother.

Steps to replicate: 1) Add two post thumbnails to a post or page. 2) Add a third post thumbnail, after the first two. 3) Click "Remove" Link on second post thumbnail. 4) Click "Add" Link on second post thumbnail.

Expected: The second thumbnail modal box to open.

Result: Third thumbnail modal box opens. When you click the "X", the third thumbnail box closes, and the second appears to have been open, just behind the third modal box.

You can replicate this again by closing out the second modal box and clicking the "Add" link on to try to cue the second thumbnail modal box. The same result happens.

Let me know if you're able to replicate this on your end! Thanks!

chrisscott commented 11 years ago

Thanks, I was able to duplicate and I'll work up a fix.

chrisscott commented 11 years ago

@ajgagnon can you pull on master, do a force reload or clear your cache, and try again? The duplication should be fixed now. Thanks.

ajgagnon commented 11 years ago

Pulled from master, cleared cache. Modal boxes are not stacking now. However, it's still pulling up the wrong modal box when I do the above steps. It appears as though the .live event was getting the correct modal box, but two boxes were up. The .on event is only getting one, but it's the wrong box. Can you confirm this on your end? Thanks Chris!

chrisscott commented 11 years ago

@ajgagnon Thanks for the update. I was able to reproduce and have a fix on master. Can you try that out and let me know?

Thanks.

ajgagnon commented 11 years ago

Issue resolved. Thank you! I'll keep testing for more bugs on my end.