Remove calls to get thumbnail post.

voceconnect / multi-post-thumbnails

Adds multiple post thumbnails to a post type. If you've ever wanted more than one Featured Image on a post, this plugin is for you.

143 stars 63 forks source link

Remove calls to get thumbnail post. #138

Open jenkoian opened 5 years ago

jenkoian commented 5 years ago

When using this plugin with https://github.com/humanmade/network-media-library it doesn't work, it seems this is because it attempts to retrieve the post of the thumbnail (needlessly afaict) which won't work because the image exists on a different site in the network.

Removing these calls seems to fix the issue and allows for a better mutli site experience. I'm not sure of any adverse affects of this, but let me know if you can see one.

jenkoian commented 5 years ago

Alternatively we could define hooks at the start and end of these functions so integrators can switch/restore blog.

jenkoian commented 5 years ago

Here's an example of the hooks approach that I've just done for a similar issue on fieldmanager https://github.com/alleyinteractive/wordpress-fieldmanager/pull/738 let me know if you'd prefer that route.