Review my app - Githubissues

vockalimo / android_hw

homework

1 stars 1 forks source link

Review my app #1

Open vockalimo opened 11 years ago

vockalimo commented 11 years ago

My app is a complete, please review. Also, I have a question about tips , is that the right way to do it? /cc @nesquena @timothy1ee

nesquena commented 11 years ago

Hi, overall your submission looks good. A few notes:

You may consider naming the view ids starting with the prefix i.e input_num => etInputNum just to keep code clarity up in the java code when working with a view
Interesting use of the seekbar view
Nice use of tag to differentiate the tip percents, you may want to change the method name from onTen to onTipCalculate

Let us know if you have any specific questions, and we will see you in class soon.