$[PLUGIN_NAME].lookup[$target.data(PLUGIN_NAME)].open(); is undefined

barbeapapier commented 7 years ago

all is on title, i get this on js console when i click on remodal button with target and id.

aischylos commented 7 years ago

Are you using ruby on rails with turbolinks?

rjcoupe commented 7 years ago

I'm having this issue as well, using the Meteor package.

If I run the JS to open the modal manually, all works fine. Weirdly though, this has only just started happening and I can't see what's changed to cause it.

cminnich commented 7 years ago

Having this issue as well, using RequireJS

Was seeing it intermittently, but have been able to replicate it under the following weirdly specific conditions:

Running my build code (the remodal plugin is minified along with the rest of my js into a single file)
Firefox incognito with Tracking Protection enabled (all other major browsers work most of the time, and the times when it doesn't work seems to be random)

The error causing condition for me is:

$[PLUGIN_NAME].lookup is an empty array
$target.data(PLUGIN_NAME) is a valid number (corresponding to the correct remodal to open) So trying to index into the empty array returns undefined, and the error is thrown when you try to open() undefined

For me, I think it was an issue with the minification/variable substitution. The solution that worked for me was to find/replace all occurrences of PLUGIN_NAME and NAMESPACE within remodal.js to the actual string value 'remodal'. I don't know why the issue was sporadic and only reproducible using Firefox Incognito with Tracking Protection...

AbdallahBedir commented 5 years ago

+1

vodkabears / Remodal

$[PLUGIN_NAME].lookup[$target.data(PLUGIN_NAME)].open(); is undefined #259