search

vogellacompany / languagetool-eclipse-plugin

Eclipse plug-in for Languagetools
Eclipse Public License 1.0
9 stars 1 forks source link

Please use languagetool as a maven dependency #5

Closed vatbub closed 7 years ago

vatbub commented 7 years ago

I have only a Windows PC and I fail to build the plugin as I can't execute shell scripts there. However, languagetool is available on maven central. My problem would be solved if you declared the dependency in your pom instead of using the sh-script. More info here.

vogella commented 7 years ago

@vatbub Awesome, sorry for the late response I was busy with the EclipseCon Europe conference. I have a look right now.

vatbub commented 7 years ago

Hi, I actually already submitted a Pull Request which fixes the issue.

vogella commented 7 years ago

Hi, I actually already submitted a Pull Request which fixes the issue.

I know, that is what I mean: I have a look (at your PR) right now. Sorry for not being clear about it.