search

vogellacompany / languagetool-eclipse-plugin

Eclipse plug-in for Languagetools
Eclipse Public License 1.0
9 stars 1 forks source link

Language tool as maven dependency #6

Closed vatbub closed 7 years ago

vatbub commented 7 years ago

Languagetool is now used as a maven dependency (more details in #5)

vatbub commented 7 years ago

Btw, you can run the build now simply with mvn package

vogella commented 7 years ago

I prefer to have the project settings for Eclipse projects checked in, to provide the same setup for all developers. Could you remove this commit from the PR?

vatbub commented 7 years ago

Here you go :)

vogella commented 7 years ago

@vatbub Interactive rebase is your friend to remove a commit. No need to have the commit and the reverted commit in the history. http://www.vogella.com/tutorials/EclipseGit/article.html#using-the-git-interactive-rebase-view

Can you also please update the README.md with the correct build instructions.

Other than that, this PR is good to go.

vatbub commented 7 years ago

Hi, sorry for not responding, I was quite busy. I actually prefer reverting as this keeps the history "real" in the sense that one can see that there was a change that has been reverted.

Anyway, I'll update the readme in just a sec. Regards, vatbub

vatbub commented 7 years ago

Oh, I just saw that you're actually a german company so Servus :)

vogella commented 7 years ago

Moin, moin :-)

Am 01.11.2016 10:09 nachm. schrieb "Frederik Kammel" < notifications@github.com>:

Oh, I just saw that you're actually a german company so Servus ;)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vogellacompany/languagetool-eclipse-plugin/pull/6#issuecomment-257698195, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIihiXAv3X5_xw0j4t6c5zAii8xeerdks5q56qKgaJpZM4KdcVT .

vogella commented 7 years ago

Thanks @vatbub

Looking forward to more fixes from you. For example, if I remember correctly the cursor position did change if I apply a suggestion via quickfix.