search

vogler / free-games-claimer

Automatically claims free games on the Epic Games Store, Amazon Prime Gaming and GOG.
GNU Affero General Public License v3.0
2.21k stars 139 forks source link

epic-games: captcha on login: await notify #195

Closed kevinmatthe closed 10 months ago

kevinmatthe commented 10 months ago

Adding async handle in captcha notify

kevinmatthe commented 10 months ago

With this issue #191

kevinmatthe commented 10 months ago

@vogler I'm not familiar in front-end develop, so if there's any problem, please just directly point out~

vogler commented 10 months ago

Did you test if that fixes #191? Adding async/await shouldn't make a difference here since the call to notify will be on the task queue either way. (At least in theory, here's some nice visualization: https://dev.to/lydiahallie/javascript-visualized-promises-async-await-5gke)

kevinmatthe commented 10 months ago

Did you test if that fixes #191? Adding async/await shouldn't make a difference here since the call to notify will be on the task queue either way. (At least in theory, here's some nice visualization: https://dev.to/lydiahallie/javascript-visualized-promises-async-await-5gke)

yes I tested this change and the console function before the notify function is correctly print to stdout. It seems to be correctly executing sync function but not the async notify.

vogler commented 10 months ago

Ok, maybe it makes some difference in how it's scheduled.