search

vogler / free-games-claimer

Automatically claims free games on the Epic Games Store, Amazon Prime Gaming and GOG.
GNU Affero General Public License v3.0
2.21k stars 139 forks source link

GitHub Actions: build docker for PRs from forks #221

Open vogler opened 9 months ago

vogler commented 9 months ago

Currently, the workflow to build the docker image fails for PRs from forks since they don't have the env vars set to login to Docker Hub: https://github.com/vogler/free-games-claimer/actions/runs/6270872769/job/17029487465?pr=206 image

For those PRs, it should just build the image and not try to login and push. Either add a dependant workflow or some conditionals.

4n4n4s commented 9 months ago

Even setting secrets on the fork side let's the build fail see #229. I guess we need to improve it further like you mentioned here in the future.

4n4n4s commented 8 months ago

@vogler I disabled creating docker images in PRs in #229 Please check (also my other PRs 😁)