search

vogler / free-games-claimer

Automatically claims free games on the Epic Games Store, Amazon Prime Gaming and GOG.
GNU Affero General Public License v3.0
2.21k stars 139 forks source link

Added first version of Steam #222

Open 4n4n4s opened 9 months ago

4n4n4s commented 9 months ago

added some improvements over #201

sonarcloud[bot] commented 8 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

vogler commented 6 months ago

Thanks! So by default this only claims the games in steam-games.json? Not sure I understand the idea here. Is there a problem with using https://www.gamerpower.com/api/giveaways?platform=steam&type=game by default?

4n4n4s commented 6 months ago

Thanks! So by default this only claims the games in steam-games.json? Not sure I understand the idea here. Is there a problem with using https://www.gamerpower.com/api/giveaways?platform=steam&type=game by default?

It should be able to claim both. The json way could be optional as it was just my first implementation when I didn't make use of the gamerpower api yet and instead was using people posting on x (twitter) as info. Meaning we can also drop this and just use gamerpower.

KairuByte commented 6 months ago

Just tested this out.

First issue I ran into is that this appears to assume it's being run within .\src which goes against all other modules. Editing the .\config.js and .\util.js pointers to point to the proper folder instead of root allows the module to run.

Next issue is that it is looking for a:has-text("Sign In") which is incorrect, it should actually be looking for a:has-text("login").

The final notification also doesn't seem to mention there are games which can be claimed outside of steam. This might be a good optional value, since some people will want fully automated solutions, and some may want a convenient way to tap into the places they need to, in order to get the games manually.

Finally, SHOW=0 is not honored.