Closed zockol closed 2 weeks ago
I just don't understand why you replaced the single quotation mark with a double quotation mark generally generated unnecessary changes
that was my vs code addon, forget to disable it here
Thanks, but please undo the unrelated syntactic changes first, otherwise it's hard to read what changed semantically. https://semanticdiff.com may help.
Ok, better to read now.
The only two relevant changes I see so far are changing the locator here: https://github.com/vogler/free-games-claimer/pull/224/files#diff-e35468b40bc179e267a0d50f7aa118eeaf03dcf676da75ac50a251b575c7c9bdR328-R330
and adding .first()
here: https://github.com/vogler/free-games-claimer/pull/224/files#diff-e35468b40bc179e267a0d50f7aa118eeaf03dcf676da75ac50a251b575c7c9bdR350
The rest is commented out and partially duplicated code.
Yea thats about it. i commented stuff out because that code not works with the new one so far and i have only worked on the loot claiming yet.
This needs to be looked at. That should be a temp replacement for the old stuff. i mentioned that i ran out of offers to test so its commented until someone could approve https://github.com/vogler/free-games-claimer/pull/224/files#diff-e35468b40bc179e267a0d50f7aa118eeaf03dcf676da75ac50a251b575c7c9bdR375-R385
Kudos, SonarCloud Quality Gate passed!
I'll close this or were there some changes that should be taken over?
code wasn't working for the new layout. swapped a few lines to collect loot again but there is still a bit to do. i marked a line with //TODO (line 525) where the bot should post the code as console.log but i ran out of prime offers to test out the code. Also there was a bug with the unlinked stores that i just fixed temporarily by removing some other stuff about it (around line 521)