search

vogler / free-games-claimer

Automatically claims free games on the Epic Games Store, Amazon Prime Gaming and GOG.
GNU Affero General Public License v3.0
2.21k stars 139 forks source link

Allow forks to publish docker images #229

Closed 4n4n4s closed 8 months ago

vogler commented 8 months ago

Thanks a lot! As I understand, this PR now allows forks to publish their own image if logins are set. What's the planned behavior? Images for PRs here aren't built. I guess they should be built but just not pushed. I also had some comment there that pull_request only triggered on creation, not on every push, but not sure if that's true.

vogler commented 8 months ago

(Also, probably best to avoid force-pushing since it may screw up reviews etc.)

4n4n4s commented 8 months ago

Thanks a lot!

As I understand, this PR now allows forks to publish their own image if logins are set.

Correct

What's the planned behavior? Images for PRs here aren't built. I guess they should be built but just not pushed.

I introduced it so that on forks you can also have your image and then test it quickly without requiring the merge here to have it somewhere easily accessible. Could be quite helpful for future store and quick/bugfixes.

I also had some comment there that pull_request only triggered on creation, not on every push, but not sure if that's true.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request according to this it also triggers on "edited".

vogler commented 8 months ago

Made some changes, probably some more adjustments are needed to get the desired behavior.