vogler / free-games-claimer

Automatically claims free games on the Epic Games Store, Amazon Prime Gaming and GOG.
GNU Affero General Public License v3.0
2.2k stars 139 forks source link

GOG: Timeout on screenshot #240

Closed QAQ5555 closed 8 months ago

QAQ5555 commented 8 months ago

started checking gog

Signed in as ***

Current free game: Blacksad: Under the Skin - https://gog.com/en/game/blacksad_under_the_skin

--- Exception:

locator.waitFor: Timeout 60000ms exceeded.

=========================== logs ===========================

waiting for locator('#giveaway:not(.is-loading)') to be visible

============================================================

at file:///fgc/gog.js:103:54 {

name: 'TimeoutError'

}

sleeping

The free game has ended but it has not been detected and cannot be saved until it times out.

televisi commented 8 months ago

I received the same error on gog. By the way, great script! thank you!

Targunitoth commented 8 months ago

It seems like a problem of GOG with Firefox, when you are logged in: grafik It loads if you are logged out or open the page with Crome: grafik

mgrimace commented 8 months ago

I've been experiencing the same error, and in the meantime as a workaround I've been using GOG's autoclaim link: https://www.gog.com/giveaway/claim

Also in Discussion #242, it appears to be a simple .json output with "" means claimed and if you visit the link a second time it should say "already claimed". Might be useful to integrate this into the script if the current process is no longer working.

4n4n4s commented 8 months ago

Same issue here. The bug is where a screenshot is taken of the banner we should skip that check.

televisi commented 8 months ago

I've been experiencing the same error, and in the meantime as a workaround I've been using GOG's autoclaim link: https://www.gog.com/giveaway/claim

Also in Discussion #242, it appears to be a simple .json output with "" means claimed and if you visit the link a second time it should say "already claimed". Might be useful to integrate this into the script if the current process is no longer working.

Sorry, how do you that in the script? Unless you were referring to a manual website access every second day?

mgrimace commented 8 months ago

Sorry, how do you that in the script? Unless you were referring to a manual website access every second day?

Manually by visiting the link. It might be beneficial to use it in the script but I don’t know enough about coding to make that PR myself.

vogler commented 8 months ago

@mgrimace That's already what it does: https://github.com/vogler/free-games-claimer/blob/3ddf1720bb10d1995bcf36a924805d5349ff8b63/gog.js#L107-L113

It just hangs to make a nicer screenshot... https://github.com/vogler/free-games-claimer/blob/3ddf1720bb10d1995bcf36a924805d5349ff8b63/gog.js#L102

Commented it out for now which should fix the timeout. Let me know when there's a new giveaway, then we can try to have a nice screenshot as well :)