No From-User ends up in malformed From-User on the otherside of SBC-OS

[khorsmann]

I tried the REGISTERED MODE in my lab and i saw this behavoir. My Softphone dont set the FROM User - its only sip:172.20.100.166.

I know i can add an own if statement but then the config differs from "vanilla".

$fU - From URI username - if $fU is empty then it should not filed up From: sip:@mysbc.host.com;tag=788860019 seems broken to me.

----------------------------
SBC-OS 172.20.160.167 TRUSTED
SBC-OS 172.20.160.168 UNTRUSTED

INVITE sip:tetris@172.20.160.168:5060 SIP/2.0
Max-Forwards: 20
Via: SIP/2.0/UDP 172.20.100.166:5060;rport;branch=z9hG4bK1885587274
From: <sip:172.20.100.166>;tag=788860019
To: <sip:tetris@172.20.160.168:5060>
Call-ID: 18647615@172.20.100.166
CSeq: 6 INVITE
User-Agent: YATE/5.5.0
Contact: <sip:tetris@172.20.100.166:5060>
Allow: ACK, INVITE, BYE, CANCEL, OPTIONS, INFO
Content-Type: application/sdp
Content-Length: 508

----------------------------
2019/05/13 12:22:34.099403 172.20.160.167:5060 -> 212.xx.xx.xx:5060
INVITE sip:tetris@sip100.xxxxxx:5060 SIP/2.0
Via: SIP/2.0/UDP 172.20.160.167;branch=z9hG4bKcd72.6992983b07d1c8269b4594fbcb7dd4b9.0
Max-Forwards: 19
From: <sip:@mysbc.host.com>;tag=788860019
To: <sip:tetris@mysbc.host.com>
Call-ID: 18647615@172.20.100.166
CSeq: 6 INVITE
User-Agent: YATE/5.5.0
Allow: ACK, INVITE, BYE, CANCEL, OPTIONS, INFO
Content-Type: application/sdp
Content-Length: 534
X-Group-SBC: 301
X-Routing-SBC: register un2tr-cgn-reg
Contact: <sip:btpsh-5cd94477-3448-1@172.20.160.167>

[adubovikov]

Yes, need to add FU check. Thanks for this

[adubovikov]

https://github.com/voiceboys/sbcOS/commit/02bb80143c26cd8d2ee70aadfc1be7aabebe5fd1

[khorsmann]

@adubovikov - Alex - i supplied a patch. 😃

[adubovikov]

should be fine now :-)

[khorsmann]

Tested and works for me.