voiceip / tinyphone

Minimalist Windows / OSx / Linux SIP Softphone with API Control
GNU General Public License v3.0
117 stars 36 forks source link

Ring and delay X sec when auto-answer (optional) #23

Closed Rysakov1986 closed 3 years ago

Rysakov1986 commented 3 years ago

Hello!

In the latest version you have disabled ring for auto answer.

But, please tell me, you can add a delay (optional in config.json autoAnswerDelay: [seconds]) for auto-answer and if autoAnswerDelay is enabled (maybe check exist optional autoAnswerDelay and/or autoAnswerDelay > 0 seconds) then play ring?

Thanks!

kingster commented 3 years ago

There was never any ring on incoming calls. The last change added ringing sound for cases when auto answer is disabled.

Ring for autoAnswerDelay can certainly be a feature which can be added.

Rysakov1986 commented 3 years ago

Great news! Looking forward to updating from autoAnswerDelay! Thanks!

kingster commented 3 years ago

Hi @Rysakov1986 Can you tryout the build from #25 and test out the feature?

Rysakov1986 commented 3 years ago

Hi @Rysakov1986 Can you tryout the build from #25 and test out the feature?

Yes, i go to test feature)

Rysakov1986 commented 3 years ago

Sorry, I accidentally closed the issue, now I'm checking the feature

Rysakov1986 commented 3 years ago

The feature works, but this implementation of the feature presents other problems:

  1. While waiting, tiny is not available via rest api.
  2. If the initiator drops the call while waiting, tiny waits until the timeout expires.

For example, I set a wait for 10 seconds, but I wanted to try to get information about the call, but I didn’t succeed until the waiting time expired.

And I wanted to try the opportunity until the time ran out of waiting with my manually to answer the call (think that for this I will need to create a new issue, right?).

kingster commented 3 years ago

That shouldn't happen, the API shouldn't have blocked. Let me see what the issue is.

kingster commented 3 years ago

@Rysakov1986 Can you try with the latest build from the PR (Build tinyphone 1.0.163) ?

Rysakov1986 commented 3 years ago

It`s works great! Thanks!!!