search

voiceip / tinyphone

Minimalist Windows / OSx / Linux SIP Softphone with API Control
GNU General Public License v3.0
117 stars 36 forks source link

Repair Dockerfile.base #44

Closed daviidmart closed 3 years ago

AppVeyorBot commented 3 years ago

:white_check_mark: Build tinyphone 1.0.187 completed (commit https://github.com/voiceip/tinyphone/commit/c6ec7ba1da by @daviidmart)

AppVeyorBot commented 3 years ago

:white_check_mark: Build tinyphone 1.0.187 completed (commit https://github.com/voiceip/tinyphone/commit/c6ec7ba1da by @daviidmart)

kingster commented 3 years ago

Thanks for the fix, it has been quite some time I used this docker based build!

Btw, I am not sure about mcr.microsoft.com/dotnet/framework/runtime vs mcr.microsoft.com/dotnet/framework/sdk. Were you able to build the tinyphone_installer.msiwith this changes?

kingster commented 3 years ago

Hey!

Thanks for your pr, there were some more fixes that were required. Have fixed it in https://github.com/voiceip/tinyphone/commit/9b7da508874a7b8ad89b6e0360ef972ace57c077 which also updates the documentation of how to build using docker.