search

voicesauce / opensauce-python

Voice analysis software (Python port of VoiceSauce)
Apache License 2.0
53 stars 16 forks source link

OpenSauce doesn't work on Windows #17

Closed terriyu closed 7 years ago

terriyu commented 7 years ago

I tested the code on Windows 7, using Anaconda and Python 2.7. The big problem right now is that the new command line interface uses a new method for calling Snack in snack.py, which doesn't work on Windows. The old version, snack_ks.py, seems to work, so we should look into using the old code.

terriyu commented 7 years ago

I realized we can use the same standalone binary executable snack.exe that Voicesauce uses. This will be much easier to support since the Windows user won't have to setup and install Tcl/Tk and Snack.

terriyu commented 7 years ago

There are still a lot of failing tests and errors when I run the unit tests on Windows. I think some of them have to do with parsing errors like how backslashes are interpreted differently on Windows.

terriyu commented 7 years ago

Implemented method of calling Snack through binary executable, so Windows users won't have to install Tcl/Tk and Snack manually. See commit https://github.com/voicesauce/opensauce-python/commit/e836fe6217fb6aeb1539e4fb66f41168b49f901b

Fixed bugs (mostly backslash problems), so that tests pass on Windows in both Python 2 and Python 3.

For more info, see the commits: https://github.com/voicesauce/opensauce-python/commit/111c623e799f39668fdc7624f8796ee79c04e563, https://github.com/voicesauce/opensauce-python/commit/e187454b903664782dc1cecef986a3e5d32a8622, and https://github.com/voicesauce/opensauce-python/commit/a247f25876166832bffceb6ba868551b87db9a08