Closed terriyu closed 7 years ago
The solution is to write our own rounding function using NumPy functions. Since it uses NumPy, it works in both Python2 and Python3.
See this commit for the solution https://github.com/voicesauce/opensauce-python/commit/f2cfe4a8900542d43c0ddf8140f4f5292195d76d
Apparently, there is an issue with rounding in Python 3. This comes up in the implementation of
shr_pitch()
:Quoted from this commit: https://github.com/voicesauce/opensauce-python/commit/7dcb050c1d6be9138e57613c2c44a6882656cb12#diff-7953eb3de436b3d0e74a60971a8b027aR78
Currently, the code passes all tests except for anything involving
shr_pitch()
because of this rounding problem.