search

voicesauce / opensauce-python

Voice analysis software (Python port of VoiceSauce)
Apache License 2.0
53 stars 16 forks source link

Resampling function gives different values in SciPy v1.0+ #29

Closed terriyu closed 6 years ago

terriyu commented 6 years ago

The SciPy function signal.resample() gives different values for SciPy versions < 1.0 and versions >= 1.0. The values don't seem drastically different for most of the resampled points, but it is numerically significant and causes the unit tests to fail if SciPy version 1.0 is used. This is because the resampled data in the test data was generated using SciPy version < 1.0.

terriyu commented 6 years ago

I assume that people will use the latest version of SciPy, so I've re-generated the test data using SciPy v1.0. This issue is fixed in commits https://github.com/voicesauce/opensauce-python/commit/81a3c86f9b95937138e5def22116399a07d230b6 and https://github.com/voicesauce/opensauce-python/commit/7324ca77d92a2f48868357f44e68c4be7c3df3d3.