voicis / nodebb-plugin-sso-battle.net

SSO for battlenet
MIT License
1 stars 0 forks source link

Users registering with Battle.net still have temporary username after registration #7

Open jdutriaux opened 6 years ago

jdutriaux commented 6 years ago

Hello,

I'm having a weird behavior: Users that creates a new account using Battle.net don't have their username edited upon registration. The username stay as battlenet-123456789 and I have to manually edit it (Just open the "Edit Username" menu and click save as the good username is already written in the input, here is the weird part). If I don't manually update the username it causes some troubles in the profile routing (Users have 404 errors when they edit things like profile picture), rights management (Unable to find an user usign the displayed username) and things like mentions and reply buttons on topics (Still using the temporary username instead displayed one).

Thanks for your help :smile:

voicis commented 6 years ago

Hi,

I was not able to reproduce the exact issue, however I noticed that it was not possible to change the username to battlenet-123456789, because it was too long. Perhaps that is causing the issues.

It seems that if new user after authorizing with Blizzard cancels the registration form, the user is still there and on next login is automatically logged in. I think in this case the user still should be presented the registration form with username and email fields. If I understood your problem correctly, then this should also fix it.

jdutriaux commented 6 years ago

Okay, thanks for the answer.

I will try to give you some steps to reproduce the bug if I have more time ;).