void-linux / runit

The init system for Void Linux.
https://voidlinux.org
162 stars 22 forks source link

Fix clang warnings #26

Open 0x5c opened 1 year ago

0x5c commented 1 year ago

When building with clang, we get a different set of warnings than with gcc. This is my attempt at fixing them.

I also found and removed unused functions that had no implementations.

rilysh commented 1 year ago

@0x5c runit has mix of K&R C (C78) and some ANSI C. I saw in several places, you've used ANSI C like function declaration. Note that this was intentional to use older version of C to make runit compatible as much UNIX-based platforms as it could and generally compiler warnings doesn't necessarily means anything wrong. Compilers are just ahead of time and very old compilers may fail to compile, if they don't satisfy with the standard.