void-linux / void-mklive

The Void Linux live image maker
https://voidlinux.org
Other
328 stars 194 forks source link

Add option to ingore services #372

Open Calandracas606 opened 8 months ago

Calandracas606 commented 8 months ago

Pretty self explanatory. If I dont want to enable some services which would be enabled by default (elogind, polkit), I can disable them with -D "elogind polkit"

I'm not sure if I should be committing the generated content from make README.md

paper42 commented 8 months ago

as far as I remember, all services have to be explicitly enabled with an argument to mklive. Just don't list the services if you don't want them to be enabled.

Calandracas606 commented 8 months ago

when using build-x86-images.sh some services are passed implicitly

paper42 commented 8 months ago

then just edit build-x86-images.sh, I don't see a reason to have a mklive.sh argument that removes services that were added by another argument, just remove it from that argument

Calandracas606 commented 8 months ago

For more context, I'm ignoring some packages when building by using the -g "eudev dbus elogind" which would otherwise be enabled by default

The image fails to build because mklive.sh tries to enable the services which are provided by packages which have been ignored.

This use case is very niche, and if this doesn't seem useful then go ahead and close the PR