leahneukirchen commented 6 years ago

This issue resumes https://github.com/voidlinux/void-packages/issues/14633.

gcc 8.2 is out now, and we should see which remaining packages are broken and how to fix them.

pullmoll commented 6 years ago

I will move my current set of packages built to a safe place and then start another cycle of bootstrapping with gcc-8.2 to see how far I get.

Edit: I will also try to update the gcc template to mpfr-4.0.1 at the same time. Edit2: isl-0.20 won't play with gcc, so I'll go with isl-0.16.1.

leahneukirchen commented 6 years ago

Arch uses isl 0.19.

pullmoll commented 6 years ago

Ok, I'll go with isl-0.19 then and update isl15 for cross-* as well.

pullmoll commented 6 years ago

base-system and base-devel built for x86_64 Packages which fail to build OOTB:

[x] grub-2.02 In file included from ../../grub-core/efiemu/runtime/efiemu.c:33: ../../include/grub/efiemu/runtime.h:36:1: error: alignment 1 of 'struct efi_variable' is less than 8 [-Werror=packed-not-aligned] } GRUB_PACKED; ^ solved with a patch
[x] xbps-0.53_4 initend.c: In function ‘xbps_init’: initend.c:416:49: error: ‘%s’ directive output may be truncated writing up to 4094 bytes into a region of size 512 [-Werror=format-truncation=] snprintf(xhp->rootdir, sizeof(xhp->rootdir), "%s/%s", cwd, buf); ^~ ~~~ initend.c:416:3: note: ‘snprintf’ output 2 or more bytes (assuming 4096) into a destination of size 512 snprintf(xhp->rootdir, sizeof(xhp->rootdir), "%s/%s", cwd, buf); ^~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[1]: [Makefile:71: initend.o] Error 1 make[1]: Leaving directory '/builddir/xbps-0.53/lib' make: [Makefile:15: all] Error 1 => ERROR: xbps-0.53_4: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 2 => ERROR: in do_build() at common/build-style/configure.sh:14 solved with a patch

[x] openssh-7.7p1 cc -o sftp progressmeter.o sftp.o sftp-client.o sftp-common.o sftp-glob.o -L. -Lopenbsd-compat/ -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,retpolineplt -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -fstack-protector-strong -L/usr/lib -pie -lssh -lopenbsd-compat -lcrypto -lldns -lz -lcrypt -ledit -lcurses /usr/bin/ld: warning: -z retpolineplt ignored. loginrec.c: In function 'construct_utmpx': loginrec.c:763:2: error: 'strncpy' output may be truncated copying 32 bytes from a string of length 511 [-Werror=stringop-truncation] strncpy(utx->ut_user, li->username, ^~~~~~~~~~~ MIN_SIZEOF(utx->ut_user, li->username));


loginrec.c: In function 'record_failed_login':
loginrec.c:1687:2: error: 'strncpy' specified bound 32 equals destination size [-Werror=stringop-truncation]
strncpy(ut.ut_user, username, sizeof(ut.ut_user));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
loginrec.c:1696:2: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
strncpy(ut.ut_host, hostname, sizeof(ut.ut_host));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:160: loginrec.o] Error 1
=> ERROR: openssh-7.7p1_2: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-configure.sh:13
**solved with a patch**

[x] Linux kernel plugin support disabled
[ ] Maelstrom-3.0.6a_1 fails for const char* vs. char * mismatches, e.g.: main.cpp:246:49: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings] mesg("Checksum = %s\n", get_checksum(NULL, 0)); I think we will see several packages failing to build for this reason, as it's a common bug to omit const where it belongs.
[x] xf86-video-intel-2.99.917.831_2 for i686{,-musl} In file included from gen4_vertex.c:34: gen4_vertex.c: In function 'emit_vertex': sna_render_inline.h:40:26: error: inlining failed in call to always_inline 'vertex_emit_2s': target specific option mismatch static force_inline void vertex_emit_2s(struct sna *sna, int16_t x, int16_t y) ^~~~~~ gen4_vertex.c:308:25: note: called from here
define OUT_VERTEX(x,y) vertex_emit_2s(sna, x,y) / XXX assert(!too_large(x, y)); /
```
                 ^~~~~~~~~~~~~~~~~~~~~~~~
```
gen4_vertex.c:360:2: note: in expansion of macro 'OUT_VERTEX' OUT_VERTEX(dstX, dstY); ^~~~~~ make[4]: [Makefile:690: gen4_vertex.lo] Error 1 make[4]: Leaving directory '/builddir/xf86-video-intel-2.99.917.831/src/sna' make[3]: [Makefile:709: all-recursive] Error 1 make[3]: Leaving directory '/builddir/xf86-video-intel-2.99.917.831/src/sna' make[2]: [Makefile:622: all-recursive] Error 1 make[2]: Leaving directory '/builddir/xf86-video-intel-2.99.917.831/src' make[1]: [Makefile:486: all-recursive] Error 1 make[1]: Leaving directory '/builddir/xf86-video-intel-2.99.917.831' make: *** [Makefile:418: all] Error 2 => ERROR: xf86-video-intel-2.99.917.831_2: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 2 => ERROR: in do_build() at common/build-style/gnu-configure.sh:13
[x] efl-1.20.7 fails for various reason efl-1.21.0-beta2 succeeds with disable_parallel_build=yes
[x] blender-2.79b_5 /builddir/blender-2.79b/intern/cycles/util/../util/util_sseb.h: In function 'const ccl::sseb ccl::shuffle(co nst ccl::sseb&)': /builddir/blender-2.79b/intern/cycles/util/../util/util_sseb.h:119:26: error: could not convert '_mm_shuffle _epi32(a, ((((i3 << 6) | (i2 << 4)) | (i1 << 2)) | i0))' from 'm128i' {aka 'vector(2) long long int'} to 'const ccl::sseb' return _mm_shuffle_epi32(a, _MM_SHUFFLE(i3, i2, i1, i0));
```
**solved with 2 patches**
```

leahneukirchen commented 6 years ago

Is the bumped branch public? Then I can debug locally.

leahneukirchen commented 6 years ago

Fix at https://git.archlinux.org/svntogit/packages.git/tree/trunk/0008-Fix-packed-not-aligned-error-on-GCC-8.patch?h=packages/grub&id=0c7d22e66884c85574eca8ce7df9571748aabb29

pullmoll commented 6 years ago

The bumped branch is in my fork's master. The patch works fine and I'll add a commit.

pullmoll commented 6 years ago

base-chroot{,-musl} for the 4 native architectures is completed. Now building base-system.

pullmoll commented 6 years ago

Unrelated note: the bootstrap dependency loop between librsvg and vala is back or still there. You have to build librsvg with -o ~vala first, then build it again to make all dependencies, and finally build with -f to have a librsvg with vala enabled.

leahneukirchen commented 6 years ago

librsvg-devel-2.40.20_4 doesn't contain vala stuff here oO.

I guess this should be moved to a separate package then.

leahneukirchen commented 6 years ago

The vala stuff resides in librsvg, where it doesn't belong.

due to a typo: $build_options_vala

pullmoll commented 6 years ago

cross-arm-none-eabi needs a fix for the patch to enable multiarch. I tried it, but it fails because of some part of the build requiring hard float for arm? I guess that needs to be fixed by its maintainer @teajay-fr .

pullmoll commented 6 years ago

architecture	packages built
aarch64-musl	1815
aarch64	1873
armv5tel-musl	1042
armv5tel	890
armv6l-musl	1785
armv6l	1886
armv7l-musl	1791
armv7l	1895
i686-musl	4448
i686	4655
mips-musl	2896
mipsel-musl	2912
mipselhf-musl	2923
mipshf-musl	2928
x86_64-musl	4523
x86_64	7499
noarch	2000

pullmoll commented 6 years ago

@chneukirchen I don't understand. srcpkgs/librsvg/template has if [ "$build_option_vala" ]; then which should be right, no? Yet there is no usr/share/vala data in librsvg-devel... strikes me a bit odd.

leahneukirchen commented 6 years ago

No, the variable is spelt wrong with an s.

pullmoll commented 6 years ago

New issue with linux4.14 and plugins:

Cannot use CONFIG_GCC_PLUGINS: your gcc installation does not support plugins, perhaps the necessary headers are missing?
make: *** [scripts/Makefile.gcc-plugins:70: gcc-plugins-check] Error 1
=> ERROR: linux4.14-4.14.61_1: do_build: 'make ARCH=$arch ${_version} ${_cross} ${makejobs} prepare' exited with 2
=> ERROR:   in do_build() at srcpkgs/linux4.14/template:95

IMHO we really should get rid of the plugin stuff for the kernels.

leahneukirchen commented 6 years ago

Yes, let's do it.

pullmoll commented 6 years ago

Live images for testing.

teajay-fr commented 6 years ago

I didn't get time to look into the issue you mentioned about the cross-arm-none-eabi. Is the issue still present ? I will find some time in the next days to look into it.

pullmoll commented 6 years ago

@teajay-fr : no problem. The package is marked as broken for the update, so it will be built only after you found time to do whatever is necessary to build it for gcc-8.2.0.

thypon commented 6 years ago

Can we fallback to disable GCC plugins only in case of errors?

pullmoll commented 6 years ago

@thypon I guess you meant to add --enable-plugins to gcc's template? I think that's ok. Opinions?

Edit: Updated #1650 to include --enable-plugins. Do you also need it for the cross compilers?

pullmoll commented 6 years ago

Mission accomplished. Except for the aarch64 builders which need to be kicked to build gcc-8.2.0 for the host first. cc @chneukirchen

pullmoll commented 6 years ago

TODOs:

[ ] revbump linux3.16
[ ] revbump or remove linux3.18 (EOL)
[ ] revbump or remove linux4.1 (EOL)
[x] revbump linux4.14
[ ] drop linux4.15
[ ] drop linux4.16
[x] revbump linux4.17
[x] revbump linux4.18
[x] modify cross-vpkg-dummy shlib_provides for libgfortran.so.5

mvf commented 6 years ago

1799 fixes the `mozc` build with GCC 8.2

pullmoll commented 6 years ago

cross-vpkg-dummy also needs a host build on the aarch64 builders

void-linux / void-packages

Tracking: GCC 8.2 #1525

define OUT_VERTEX(x,y) vertex_emit_2s(sna, x,y) / XXX assert(!too_large(x, y)); /

1799 fixes the `mozc` build with GCC 8.2

void-linux / void-packages

Tracking: GCC 8.2 #1525

define OUT_VERTEX(x,y) vertex_emit_2s(sna, x,y) / XXX assert(!too_large(x, y)); /

1799 fixes the mozc build with GCC 8.2

1799 fixes the `mozc` build with GCC 8.2