search

void-linux / void-packages

The Void source packages collection
https://voidlinux.org
Other
2.59k stars 2.16k forks source link

firefox-i18n-fr installed, firefox still in english #27255

Closed eoli3n closed 5 months ago

eoli3n commented 3 years ago

System

Expected behavior

firefox defaulty configured in french

Actual behavior

firefox starts in english, and french is not disponible in languages menu.

Steps to reproduce the behavior

just install the package.

loreb commented 3 years ago

I'm fine with firefox in English, but since nobody replied yet...

The expected behavior is inexcusably wrong - you may not have a shared computer, but they do exist, and it would really annoy other people using the same computer if it happened.

I would also expect the language in the languages menu, but it's not; it CAN be added installing from a file (deep down in /usr/lib/firefox); I have no idea if updates work this way, and the behavior is confusing.

ericonr commented 3 years ago

Ok, so I've noticed this issue when I was touching Thunderbird, but couldn't figure out what was missing.

It would be nice to fix it, tho.

Chocimier commented 3 years ago

Going to addons, then installing translation from disk works for now. No need to repeat on update.

ericonr commented 3 years ago

@Chocimier maybe we can add that to docs, at least?

travankor commented 3 years ago

Going to addons, then installing translation from disk works for now. No need to repeat on update.

should the language packages be removed if this is the way forward?

eoli3n commented 3 years ago

it seems strange to me that this is so hard to fix. Could it be related to the way the package is built ?

In firefox PKGBUILD, some things which could be related to this, that i can't find in template:

It seems that Archlinux firefox-i18n package only put the file and firefox package process it. Void has some scripting in firefox-i18n.

eoli3n commented 3 years ago

From https://firefox-source-docs.mozilla.org/intl/locale.html#requested-locales

After the sanitization, the value will be stored in a pref intl.locale.requested. [...]

  • If the pref is not set at all, Gecko will use the default locale as the requested one.

It seems that PKGBUILD does this as shown in my previous comment: Use LANG env var. Void package fallback to default locale (?) because no intl.locale.requested is set. We can also read:

If the developer wants to programmatically request the app to follow OS locales, they can assign null to requestedLocales.

eoli3n commented 3 years ago

Affects firefox-esr package too.

eoli3n commented 3 years ago

I can't build firefox package with default template: https://x0.at/wFT.txt

=> firefox-84.0_1: installing host dependencies: autoconf213-2.13_4 unzip-6.0_14 zip-3.0_6 pkg-config-0.29.2_2 perl-5.32.0_1 python3-3.9.1_1 yasm-1.3.0_2 rust-1.48.0_1 cargo-0.49.0_1 llvm-11.0.0_1 clang-11.0.0_1 nodejs-lts-10-10.23.0_1 cbindgen-0.15.0_1 python-2.7.18_2 nasm-2.15.05_1 which-2.21_3 tar-1.32_3 ...
=> firefox-84.0_1: installing target dependencies: nss-devel-3.59_1 libjpeg-turbo-devel-2.0.6_1 gtk+-devel-2.24.32_3 gtk+3-devel-3.24.24_1 icu-devel-67.1_1 pixman-devel-0.40.0_1 libevent-devel-2.1.12_1 libnotify-devel-0.7.9_1 libvpx-devel-1.9.0_1 libXrender-devel-0.9.10_2 libXcomposite-devel-0.4.5_1 libSM-devel-1.2.3_1 libXt-devel-1.2.0_1 rust-std-1.48.0_1 libXdamage-devel-1.1.5_1 freetype-devel-2.10.4_1 alsa-lib-devel-1.2.4_1 dbus-glib-devel-0.110_1 pulseaudio-devel-14.0_2 libXScrnSaver-devel-1.2.3_1 sndio-devel-1.7.0_3 jack-devel-1.9.16_1 ...
=> firefox-84.0_1: running pre-build hook: 02-script-wrapper ...
=> firefox-84.0_1: running do_build ...
 0:00.68 Failed to parse ccache stats output: secondary config (readonly)         /etc/ccache.conf
 0:05.75 Clobber not needed.
 0:05.76 Adding make options from /builddir/firefox-84.0/.mozconfig
    MOZ_OBJDIR=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu
    OBJDIR=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu
    FOUND_MOZCONFIG=/builddir/firefox-84.0/.mozconfig
    export FOUND_MOZCONFIG
 0:05.79 /usr/bin/make -f client.mk -s
 0:06.95 Elapsed: 0.83s; From dist/include: Kept 5815 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:07.09 Elapsed: 0.00s; From dist/public: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:07.22 Elapsed: 0.00s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:07.35 Elapsed: 0.00s; From dist/xpi-stage: Kept 5 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:07.67 Elapsed: 0.19s; From _tests: Kept 577 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:08.23 Elapsed: 0.43s; From dist/bin: Kept 2576 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:08.28 ./buildid.h.stub
 0:08.51 ./source-repo.h.stub
 0:09.69 toolkit/library/rust/force-cargo-library-build
 0:16.38    Compiling xpcom v0.1.0 (/builddir/firefox-84.0/xpcom/rust/xpcom)
 0:31.93 error: could not compile `xpcom`
 0:31.94 Caused by:
 0:31.94   process didn't exit successfully: `/usr/bin/rustc --crate-name xpcom --edition=2018 xpcom/rust/xpcom/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no -C metadata=8e663ebdaf450182 -C extra-filename=-8e663ebdaf450182 --out-dir /builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/builddir/firefox-84.0/build/cargo-linker -L dependency=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/x86_64-unknown-linux-gnu/release/deps -L dependency=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/release/deps --extern libc=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/x86_64-unknown-linux-gnu/release/deps/liblibc-13a0d9a00e0d07bb.rmeta --extern nserror=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/x86_64-unknown-linux-gnu/release/deps/libnserror-63984d8617426e65.rmeta --extern nsstring=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/x86_64-unknown-linux-gnu/release/deps/libnsstring-fbc9ba847dbb4634.rmeta --extern thin_vec=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/x86_64-unknown-linux-gnu/release/deps/libthin_vec-2b13eb11d87d4d8a.rmeta --extern threadbound=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/x86_64-unknown-linux-gnu/release/deps/libthreadbound-11d58741b2893b0e.rmeta --extern xpcom_macros=/builddir/firefox-84.0/obj-x86_64-unknown-linux-gnu/release/deps/libxpcom_macros-c17705735d405104.so -C opt-level=2 -C debuginfo=2 --cap-lints warn -Cembed-bitcode=yes -C codegen-units=1` (signal: 9, SIGKILL: kill)
 0:31.97 make[4]: *** [/builddir/firefox-84.0/config/makefiles/rust.mk:319: force-cargo-library-build] Error 101
 0:31.97 make[3]: *** [/builddir/firefox-84.0/config/recurse.mk:72: toolkit/library/rust/target] Error 2
 0:31.97 make[2]: *** [/builddir/firefox-84.0/config/recurse.mk:34: compile] Error 2
 0:31.97 make[1]: *** [/builddir/firefox-84.0/config/rules.mk:355: default] Error 2
 0:31.99 make: *** [client.mk:89: build] Error 2
 0:31.99 0 compiler warnings present.
 0:32.20 Failed to parse ccache stats output: secondary config (readonly)         /etc/ccache.conf
=> ERROR: firefox-84.0_1: do_build: './mach build' exited with 2
=> ERROR:   in do_build() at srcpkgs/firefox/template:172
Anachron commented 3 years ago

signal: 9, SIGKILL: kill --> You probably want to check if you're running out of resources.

eoli3n commented 3 years ago

Oh ok, i work in a VM, that's why, thanks

Chocimier commented 3 years ago

@eoli3n, thanks for findings. We already have set intl.locale.requested and only missing allow-addon-sideload. (But I do not have enough memory to check either.)

ericonr commented 3 years ago

@Chocimier how would adding it work? I can try on thunderbird

eoli3n commented 3 years ago

@Chocimier problem will be https://blog.mozilla.org/addons/2020/03/10/support-for-extension-sideloading-has-ended/

Chocimier commented 3 years ago

@ericonr, just drop ac_add_options --allow-addon-sideload into files/mozconfig.

mvf commented 3 years ago

Going to addons, then installing translation from disk works for now. No need to repeat on update.

On my machines, language packs have to be manually reinstalled for every profile on every firefox update via XBPS.

ericonr commented 3 years ago

@Chocimier adding that into files/mozconfig makes it apply the language from the LANG env var, without having to follow any manual steps.

I will open an issue about applying it to all our mozilla stuff, and will include it in #26896

pullmoll commented 3 years ago

Oops! I didn't see this before updating firefox-esr to 78.6.1 .. should I stop builds and add that line to mozconfig?

Chocimier commented 3 years ago

@jnbr, could you include that change on next update? Thanks!

jnbr commented 3 years ago

yes, wil do

eoli3n commented 2 years ago

The problem still occurs with latest firefox update (95.0_1)

ghost commented 2 years ago

I'm fine with firefox in English

I've heard that French people don't like English language.

Anachron commented 2 years ago

Yep, it's in english for me as well even though I have german installed. This is a regression.

Chocimier commented 2 years ago

Do you see older version of language pack, or none at all on about:addons? If former, it's because pack at profile extensions/ (probably manually installed) hides system one, and need to be removed.

Anachron commented 2 years ago

They were disabled because they were incompatible with Firefox 95. I've clicked the gear icon and did "Check for Updates" and installed the updates and now my firefox is in german language again.

I think maybe it would be good to put this into the INSTALL.msg because this issue pops up quite often recently.

eoli3n commented 2 years ago

Upgraded to 95.0.1_1, firefox is in french after the restart. Does anything changed ? Or maybe that's because there is no new files in firefox-i18n ?

Anachron commented 2 years ago

Eoli3n did you try my suggestion from Dec 10th?

eoli3n commented 2 years ago

I already have that "check for updates" option checked in the gear menu. But in any cases, firefox-i18n should be able to provide the right files.

eoli3n commented 2 years ago

Upgraded to 96, still... please reopen that issue

ericonr commented 2 years ago

I think you can reopen it yourself?

I'm using the built-in language pack download and it's been working ok, but I'm not sure it's ideal.

eoli3n commented 2 years ago

If I ask, that's because I can't...

ericonr commented 2 years ago

Sorry, I thought it was always possible to reopen your own issues.

Duncaen commented 2 years ago

You could try the latest firefox release, I added some more addon related flags that arch enabled, otherwise I'm not sure how to solve this, maybe we should just drop the i18n packages.

eoli3n commented 2 years ago

For posterity https://github.com/void-linux/void-packages/commit/43366049eb57ad4cf7afad2cc05fd99eaf28f440 Already upgraded to that version, I don't remember to manually switch to fr this time, not sure, I will tell the next one :)

eoli3n commented 2 years ago

Upgrade to ff 97 = english after restart :cry:

Chocimier commented 2 years ago

Again: I am pretty sure it is manually installed translation overriding system one.

In new clean profile, is translation present? (firefox -P, then start with new profile. The profile selector is English only.) If it is, try to remove translation from your main profile and restart browser.

eoli3n commented 2 years ago

When I create a new profile and start firefox with it, language is French.

github-actions[bot] commented 2 years ago

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

eoli3n commented 2 years ago

At each upgrade, I still get the issue.

Chocimier commented 2 years ago

My guess still is that extension in profile overrides the system wide.

Did you try, before an upgrade, to

remove translation from your main profile

?

eoli3n commented 2 years ago

I'll try. But still, why is that not a problem on my arch host ?

classabbyamp commented 5 months ago

is this still occurring?

eoli3n commented 5 months ago

Nop, thanks