search

void-linux / void-packages

The Void source packages collection
https://voidlinux.org
Other
2.59k stars 2.16k forks source link

mpv does not build with the vulkan option turned off #48914

Closed Aicaya closed 8 months ago

Aicaya commented 8 months ago

Is this a new report?

Yes

System Info

Void 6.1.71_1 x86_64 AuthenticAMD uptodate rrmFFFFFFFFFFFFFF

Package(s) Affected

mpv-0.37.0_1

Does a report exist for this bug with the project's home (upstream) and/or another distro?

No response

Expected behaviour

Building mpv with vulkan disabled should work.

Actual behaviour

Build fails due to libplacebo-devel only being a dependency when the vulkan option is enabled.

I should note that the previous version of mpv built fine without it, so maybe the dependency is now mandatory? Don't really know what it does and the pull request merge seems to be recent, which is why I'm writing an issue instead of sending a fix.

Steps to reproduce

  1. ./xbps-src -o ~vulkan pkg mpv
  2. Wait.
chrysos349 commented 8 months ago

here is the release notes for mpv-0.37 regarding libplacebo. see here - https://github.com/mpv-player/mpv/releases

This is the first release to unconditionally require libplacebo, but note that the new improved renderer (vo_gpu_next) is not yet the default. ... meson: make libplacebo a required dependency

the template needs to be fixed.