search

void-linux / void-packages

The Void source packages collection
https://voidlinux.org
Other
2.5k stars 2.11k forks source link

Oilshell renamed `oil` as `ysh`, but package still uses old name #51951

Open sogaiu opened 3 weeks ago

sogaiu commented 3 weeks ago

Is this a new report?

Yes

System Info

Void 6.6.47_1 x86_64 GenuineIntel uptodate FFFF

Package(s) Affected

oil-0.22.0_1

Does a report exist for this bug with the project's home (upstream) and/or another distro?

No response

Expected behaviour

Being able to invoke ysh successfully.

Actual behaviour

Attempting to invoke ysh leads to a message that ends ysh: command not found.

Steps to reproduce

  1. sudo xbps-install -Su
  2. sudo xbps-install -S oil # ...and answer appropriately until installation is complete
  3. ysh

Regarding the renaming, please see this.

classabbyamp commented 3 weeks ago

@bugcrazy

tranzystorekk commented 3 weeks ago

According to https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines we can migrate the package to the oils-for-unix version

bugcrazy commented 2 weeks ago

I created this PR that renames the old names, ysh command, it had the old name oil, I also renamed the package name to oils, making things easier: https://github.com/void-linux/void-packages/pull/51964

bugcrazy commented 2 weeks ago

According to https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines we can migrate the package to the oils-for-unix version

"The oils-for-unix tarball is the fast shell in C++, completed in 2024. The distro package should be called oils-for-unix."

Package currently uses CPython version, I changed the package name to oils, to make it easier, although the author does not recommend it, the oils-for-unix version is faster, but has bugs than the CPython version, as it was only completed this year, the CPython version is more tested and old.

sogaiu commented 2 weeks ago

Hmm, I assumed that folks who are interested in using the oilshell-related stuff at this point are more inclined to using the more recent release. At least that is the case for me -- the whole project is quite oriented toward testing and I think they'd appreciate getting feedback from users for their more recent efforts.

Just my two cents.

icp1994 commented 2 weeks ago

I agree it makes more sense to build from the oils-for-unix-${version}.tar.gz - especially considering the instructions under 'Packaging' in https://www.oilshell.org/release/0.22.0

Also a new version was "tagged" yesterday upstream so could also incorporate the changes in an update PR.

bugcrazy commented 1 week ago

Updated to version 0.23, waiting for merge!