Code style changes

[ericonr]

So, following @Duncaen suggestions, I'm taking a look at the code for xbps-query, to start off.

        { "revdeps", required_argument, NULL, 'X' },
        { "regex", no_argument, NULL, 0 },
        { "fulldeptree", no_argument, NULL, 1 },
        { "cat", required_argument, NULL, 2 },

I noticed that a few portions of the code, for example xbps-query's main.c, are using raw ints instead of enums for some things. I feel like changing some of those to enums would make the code clearer and the process of messing with it less error prone. So, while possibly adding new features, I could also change some of those raw ints to enums.

Would there be any issue with this?

[the-maldridge]

I like this idea, but I'd like to see it come with test cases to validate behavior before and after. Ideally you'd do it as:

• evaluate test coverage before, adding tests if necessary
• make your changes
• show that the tests continue to pass after adjusting from ints to enums

As you mentioned, raw ints are error proned, so care should be taken to not make the problem any worse than it already is.

[ericonr]

Fair enough. It seems XBPS has mainly integration tests instead of unit tests, so I will have to think about how to build them.