search

void-ppc / void-packages

The Void source packages collection (all ppc platforms, staging + main)
https://repo.voidlinux-ppc.org
Other
27 stars 12 forks source link

socat: use different termios bits for ppc #29

Closed ghost closed 5 years ago

ghost commented 5 years ago

Socat currently fails on ppc due to wrong termios bits.

q66 commented 5 years ago

Indeed, you're right. Please drop the newline escaping in the strings though, also sub-indent with 1 space, like this:

    ppc*)
        configure_args+="
         sc_cv_sys_crdly_shift=12
         sc_cv_sys_tabdly_shift=10
         sc_cv_sys_csize_shift=8"
        ;;
    *)
        configure_args+="
         sc_cv_sys_crdly_shift=9
         sc_cv_sys_tabdly_shift=11
         sc_cv_sys_csize_shift=4"
        ;;

Also, since the package is orphaned, feel free to assign maintainer to me (q66 <daniel@octaforge.org>), unless you want to pick it up yourself, of course.

ghost commented 5 years ago

Oh well, it wasn't supposed to come from my master branch. But I fixed the lines that you mentioned.

q66 commented 5 years ago

Thanks. I put it in my local staging tree, updated packages as well as repo will come out with the next batch, as will an upstream void-packages submission.

ghost commented 5 years ago

Should I just do PRs for your staging branch in the future or simply upstream? I think I saw you doing bigger batches from time to time.

q66 commented 5 years ago

You can just go upstream and tag me if you want, in which case it will be pulled into the repo with other upstream changes - here is also alright though. Depends on which way is more comfortable for you (upstream repo needs more setting up for building packages as it does not have void-ppc repo paths and so on)