nodejs: Fix PowerPC CPU detection and codegen to work with more processors.

void-ppc / void-packages

The Void source packages collection (all ppc platforms, staging + main)

https://repo.voidlinux-ppc.org

Other

27 stars 12 forks source link

nodejs: Fix PowerPC CPU detection and codegen to work with more processors. #62

Closed jhamby closed 2 years ago

jhamby commented 2 years ago

Updated Node.js version from 16.13.2 to 16.14.0 and added a new patch to fix JIT code generation for pre-POWER7 CPUs, including G5 PowerMac and NXP e5500/e6500. This patch will unblock anyone who needs Node.js to work on a G5, e.g. to build Firefox, and it shouldn't affect POWER7 and newer at all.

Testing the changes

I tested the changes in this PR: YES

Local build testing

I built this PR locally for my native architecture, (ppc64-glibc)

q66 commented 2 years ago

does this supersede the other PR?

jhamby commented 2 years ago

does this supersede the other PR?

The other patch is for "nodejs-lts" (v12) and this patch is for "nodejs" (v16, the latest stable branch). I needed to get Node.js LTS working to build Firefox and I thought it would be helpful to patch this as well. I'm going to work on getting these patches upstreamed into the V8 repo.

q66 commented 2 years ago

ah, i see, gotcha

q66 commented 2 years ago

btw, as it is this does not build on musl, need some fallbacks for missing hwcap constants: https://github.com/void-linux/void-packages/blob/master/srcpkgs/nodejs/patches/xxx-ppc-hwcap-musl.patch

(you should consider that when upstreaming this)