Into the Odd Game System incompatible with Foundry VTT 0.8.6 - Githubissues

voidcase / IntoTheOdd-FoundryVTT

An implementation of the Into The Odd system by Chris McDowall for Foundry VTT

GNU General Public License v3.0

8 stars 9 forks source link

Into the Odd Game System incompatible with Foundry VTT 0.8.6 #16

Closed Lim-Dul closed 3 years ago

Lim-Dul commented 3 years ago

Observed Behavior After creating a new Actor in FVTT 0.8.6, any values entered on the character sheet, including in items, fail to save and all fields get reset. Also the section for base attributes is not displayed altogether.

Expected Behavior After creating a new Actor in FVTT 0.8.6, any values entered on the character sheet are properly saved and the base attribute section is displayed.

Steps to Reproduce

Create a new world in FVTT 0.8.6 using Into the Odd as Game System
Launch the new world as Gamemaster
Create a new actor e.g. named Test
Open the new actor and attempt to enter values into hitpoints or item statistics after adding an item; also observe the missing base attribute section

voidcase commented 3 years ago

I've started looking at this now.

I've gotten the values to show up in the sheet, but they still don't want to be updated. No error is shown in the console when I try.
Owned items should not be handled with the now deprecated getOwnedItem() and it's siblings

Lim-Dul commented 3 years ago

I think there might be a hint in other module updates. Mausritter, Mörk Borg and I believe Knave had similar problems but they fixed them. Oh, let's not forget Electric Bastionland. Also, Cairn (unsurprisingly) has this problem at the moment but the lads and lassies over there have a semi-working version, I believe.

voidcase commented 3 years ago

Thanks to reading the update commit from the EB module repo, I have now managed to make the fields visible and editable. Now it's only items and rolls left (and maybe more broken things I don't know about yet)

voidcase commented 3 years ago

Alright, item handling seems fixed now! On to the rolls. Work on this issue is done on this branch

voidcase commented 3 years ago

just updated to 0.8.8, and the sheets broke again... yay...

voidcase commented 3 years ago

False alarm, I was just on the wrong branch. Thought I was going crazy there for a sec, lol.

voidcase commented 3 years ago

version 1.2.0, compatible with foundryvtt 8.8.0 is now out :)

Lim-Dul commented 3 years ago

Works like a charm. Tested on FoundryVTT 0.8.8 with all modules disabled. Attributes are displayed and can be saved, item workflow works as expected.