voidcosmos / angular-communities

A list of all the Angular Communities around the world

https://www.angular-communities.com

MIT License

102 stars 38 forks source link

Feat/community form #67

Closed Anexon closed 5 months ago

Anexon commented 4 years ago

Hi there!

Here is what I think could work as next step into creating data structure for new community using a reactive angular form. What's in the pr:

Angular form groups to collect information about community and collaborators with input validations.
Google Maps Places to autocomplete address location and get latitude and longitude of community (needs enabled API).
Copy to clipboard generated json text according to community schema.
Link to steps to update repository and add the community.

With this we will have a digital we to generate the required schema that could be updated in the future to upload its content to firebase just by adding a service to the form component.

Here you can see working video of the form: form usage gif

Let me know what do you think, Best!

57

tonivj5 commented 4 years ago

Wow @Anexon, this is awesome :trophy:

I'll review it ASAP :+1:

Anexon commented 4 years ago

Hi there! How are you doing? Let me know if need something to merge this.

tonivj5 commented 4 years ago

Hey, I haven't forgot of you. I've been very busy these weeks. I'll try to review it later this week

Anexon commented 4 years ago

@tonivj5 wow, what a review! I appreciate it very much, you did a great work in there; great code simplification and cleaning. I've took a couple of personal notes for next contributions :D! I would like have done this review on a live session because I don't fully understand some suggestions related to move from contructor to @input and a some other. But I'm sure we can chat about them in some moment in the future :).

Thank you very much for your work @tonivj5 . I'm eager to see it in next deploys and start collaborating in other issues!

tonivj5 commented 4 years ago

I would like have done this review on a live session because I don't fully understand some suggestions related to move from contructor to @input and a some other. But I'm sure we can chat about them in some moment in the future :).

Sure! No problem :smile::+1: