search

voidcrew / Voidcrew-LRP

An LRP fork of Shiptest
https://rules.voidcrew-lrp.com
GNU Affero General Public License v3.0
13 stars 70 forks source link

not sure cricket telecomms door should be named like this. #276

Open Addust opened 2 years ago

Addust commented 2 years ago

Issue reported from Round ID: 343 (Voidcrew-LRP)

Reporting client version: 514.1575

image

GuiltyNeko commented 2 years ago

This still happens, just as a side-note.

GuiltyNeko commented 2 years ago

https://github.com/voidcrew/Voidcrew-LRP/blob/900e519bf7303422055cce3bf338d1294089264b/voidcrew/code/modules/overmap/ships/simulated.dm#L357-L373

The line of note here is 372 https://github.com/voidcrew/Voidcrew-LRP/blob/900e519bf7303422055cce3bf338d1294089264b/voidcrew/code/modules/overmap/ships/simulated.dm#L372 That leads into this proc, which leads into the next proc https://github.com/voidcrew/Voidcrew-LRP/blob/900e519bf7303422055cce3bf338d1294089264b/code/game/objects/items/blueprints.dm#L211-L230 Without looking at replacetext, my best guess here is that it's taking the original name of the area, in the code, changing it to be "[ship name] [area name]" but it's also changing the names of various bits of equipment, in a way that searches for the exact original area name in the name of the machinery, and then placing the name of the ship directly in front of the name of the area it found on the door, ignoring any and all text before or after it.