voideditor / void

https://voideditor.com
MIT License
8.01k stars 396 forks source link

Add support for ctrl+k #11

Open andrewpareles opened 1 month ago

andrewpareles commented 1 month ago

When the user presses ctrl+k, an input box should appear inline with the code that they were selecting. This is somewhat difficult to do because the vscode extension API alone doesn't support it - it requires creating a new component in the IDE.

We think we can modify vscode's built-in "codelens" or "zone widget" components to build the input box to ctrl+K, but we are open to alternatives like taking code from the "diffEditor".

inline4

AllyourBaseBelongToUs commented 1 month ago

Do everything Cursor does but OSS?

Guess you guys are on the right track

andrewpareles commented 1 month ago

We don’t plan on just copying Cursor :)

Inline edits are a pretty core feature that most AI extensions / editors support

sunmorgan commented 1 month ago

Working on it, should open a pr soon

ben-localhost commented 1 month ago

does commenting count as contribution ? can i put that on my resume ?

imcheeseberg commented 1 month ago

This Feature is available on VSCode Insider Version, called 'editorInsets', you can test it by an extension which has add "enabledApiProposals": ["editorInsets"] to package.json,but the feature is not completed as no 'setHeight' is provided.

Here is a issue lasted 5 years long.... https://github.com/microsoft/vscode/issues/85682

andrewpareles commented 1 month ago

This Feature is available on VSCode Insider Version, called 'editorInsets', you can test it by an extension which has add "enabledApiProposals": ["editorInsets"] to package.json,but the feature is not completed as no 'setHeight' is provided.

Here is a issue lasted 5 years long.... microsoft/vscode#85682

Great insight - thanks for this!

qiao-wei commented 1 month ago

why does it show the error "command 'void.ctrl+k' not found" shen i press the "ctrl+k"

andrewpareles commented 2 weeks ago

Ctrl+K still hasn't been merged into the main branch.

andrewpareles commented 2 weeks ago

For reference, see https://github.com/microsoft/vscode/pull/66418 and https://github.com/microsoft/vscode/issues/85682. We're going with editorInsets, the modern version of these. #119 has a Hello World editor inset.

sunmorgan commented 2 weeks ago

For reference, see microsoft/vscode#66418 and microsoft/vscode#85682. We're going with editorInsets, the modern version of these. #119 has a Hello World editor inset.

I don't think you can actually use it though right, they specifically mentioned that you can't use it in production. "/**

andrewpareles commented 2 weeks ago

This is true if you're building an extension. We're not just building an extension, we're building a full IDE.

andrewpareles commented 1 week ago

The basic layout for Ctrl+K is now on main. It'll be implemented soon!