voidlabs / elycharts

Interactive Javascript (SVG|VML) Charting Library
http://elycharts.com
Other
10 stars 6 forks source link

elycharts does not work with newest jquery #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to http://elycharts.com/docs, click "jsfiddle" link for "Basic usage"
2. Update jquery to 1.9.1, 1.10.1 or 2.0.2
3. Click "Run"

What is the expected output? A simple graph
What do you see instead? Nothing

What version of the product are you using? Tried Elygraph 2.1.3 and 2.1.4 trunk
On what operating system? Google Chrome

Elygraph works fine with jquery < 1.9 or if jquery-migrate is also included 
(this indicates that some deprecated functions of jquery are used).

Original issue reported on code.google.com by b.engelb...@gmail.com on 21 Aug 2013 at 5:19

GoogleCodeExporter commented 9 years ago
This is because we use $.browser.msie to detect msie and this has been removed 
since jquery 1.9.

I'm planning to switch the check from jquery msie to "Raphael.VML" but I'm not 
sure the current conditions really wanted to check IE in general or IE versions 
using VML for rendering (IE<=8 and later IE in compatible mode).

Original comment by stefano....@gmail.com on 14 Jan 2014 at 10:47

GoogleCodeExporter commented 9 years ago
Should be fixed with the latest commit! Maybe raphael 2 removed the need for IE 
specific hacks, but I don't have any example where these hacks are needed, so 
let's consider this fixed.

Original comment by stefano....@gmail.com on 14 Jan 2014 at 3:25

GoogleCodeExporter commented 9 years ago
Great, thank you!

Original comment by b.engelb...@gmail.com on 14 Jan 2014 at 4:07