voidlabs / mosaico

Mosaico - Responsive Email Template Editor
https://mosaico.io
GNU General Public License v3.0
1.71k stars 504 forks source link

In Title and Button, content is not editable when defaut content is removed #426

Closed Vgratioulet closed 6 years ago

Vgratioulet commented 6 years ago

In Firefox 52/Debian and Firefox 59/Ubuntu, on every button and title when I remove the default content then click outside the field, I can't focus on it again to write the new content. it doesn't happen on text paragraph, the field is still focusable with a black border when I mouseover it. And when I click in the rectangle I have a orange limit at the beginning and the end.

If I click in 'Content' in the button link to write an url (in the left side of the screen), the button text field (in the right side) becomes focusable again with the orange limits. There is no editable property for the title to help make the title text field focusable again. I reproduced it on https://mosaico.io/editor-0.17.4.html

bago commented 6 years ago

OK. Are you able to focus it again if you focus the previous or next editable text and use TAB or CTRL+TAB to move the focus to the "missing" editable? If yes, then it is still editable, but being empty you are not able anymore to select it via mouse. In this case it should be easier to fix. Otherwise I need more infos.. please let me know.

Vgratioulet commented 6 years ago

yes, with TAB and CTRL+TAB I can reach those fields, good work-around, thanks

bago commented 6 years ago

OK, I can reproduce it. Title and buttons are no more focusable if they are emptied. This is somehow template-related but maybe we need a fix (either in the template or in the editor) so that even empty inline editable elements can be focused.

bago commented 6 years ago

I added some defaull style to make sure inline editable are inline-block, have a minimum width and are never empty.

Vgratioulet commented 5 years ago

Works perfectly, thanks