search

voidlabs / mosaico

Mosaico - Responsive Email Template Editor
https://mosaico.io
GNU General Public License v3.0
1.7k stars 501 forks source link

css loader gif should be removed #470

Closed charles-lebrun closed 6 years ago

charles-lebrun commented 6 years ago

Hello there is two line on your css that fail compilation, because image doesn't exist, could we remove it ?

https://github.com/voidlabs/mosaico/blob/881d673073afebd868ec3fb8ed2454641865243d/src/css/style_elements.less#L495

https://github.com/voidlabs/mosaico/blob/881d673073afebd868ec3fb8ed2454641865243d/src/css/style_elements.less#L500

bago commented 6 years ago

How are you compiling this?

I guess the 2 rules are not applied at all in mosaico.. mosaico code have been extracted from a larger application and opensourced, so there is some code (expecially in css) that is not really used by mosaico, but is there because it makes it simpler for us to maintain it.

bago commented 6 years ago

No answers, closing this.