voidlabs / mosaico

Mosaico - Responsive Email Template Editor
https://mosaico.io
GNU General Public License v3.0
1.7k stars 500 forks source link

In the mail client, if content is blocked, images collapse without respecting layout #522

Closed francescogabbrielli closed 5 years ago

francescogabbrielli commented 5 years ago

When opening the e-mail in the mail client (for instance, Thunderbird), I have content (in particular images) blocked by default.

In that case a placeholder should be displayed (normally an X) andthe height of the original image is preserved.

immagine

Instead in this case the layout collapses. How can I fix this in the easiest way possible?

bago commented 5 years ago

The behaviour is "email client specific". In some block (mutliple images block) you force an height and mosaico will crop your images and add a specific width/height. In most blocks, instead, mosaico only define width while height is left "automatic" depending on the aspect ratio of your images. Given we don't put the height in the HTML you get this "issue".

In fact I think this is a feature not an issue: why someone would care to see big empty space? Isn't it better to see some text instead, before you unblock images?

I don't have a solution for you and I think there's no "easy" solution to the issue (mosaico currently doesn't even know/care what's the height of your images in that blocks, so this would require internal changes in multiple places of the code).

PS: be sure to use Alternative Text for images. PS2: thunderbird have a very low email client quota share.

bago commented 5 years ago

One option if to add a "fixed height" (or a variable defined "height") to all of editable images, like versafix-1 does in the multiple images blocks, but I think this is not a good idea in terms of UX.

PS: maybe things will change once we integrate the inline cropper ( https://cropper.mosaico.io/ ), but this is just a Proof of concept, and I don't really know if this will require "height" handling changes (I guess and hope we don't need changes)