Open jking31cs opened 13 years ago
Merge this with #15?
Now that all of the logic is solid, I'm going to start on this as soon as I make sure the security stuff is good. So this'll get worked on soon.
In user Admin is now a checkbox, i made type and course dropdown boxes instead, but left active as a checkbox option. As far as active goes, i dont see how we can rule out this as a desired behavior. It defaults to active so its not causing any usability issues
In Course Professor is now a dropdown box
I got rid of course id. I saw no reason to put this on the form as it makes it automatically. I left it to display in case it is need somewhere else or at some other time
When adding a user (and possibly editing) the error messages aren't very specific. I believe this can be done with @user.errors.messages to get all the errors out.
I kinda hate how it is working at the moment, so here are my suggestions.
Add student:
Prepopulates with admin user's details Admin should be a dropdown Type should be a dropdown Should be called "add user" Course should not be an attribute here Active should be a dropdown or not settable here
Same issues in edit user
Add course: Professor should be a dropdown of all professors in the system Not able to actually add a course
Edit course: Not tested
Remove course: Not tested
Other: Current admin page looks ugly