search

voiio / Sam

Sam – cuz your company is nothing without Sam
https://code.voiio.de/Sam/
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Introduce pre-commit and ruff #80

Closed amureki closed 6 months ago

amureki commented 6 months ago

I noticed quite some obsolete imports and other issues that went unnoticed by black+isort+pydocstyle. Also, I made several PRs where CI failed with linting issues, which was annoying to get back to and fix by running linters manually.

I decided to replace it all with ruff and also introduce pre-commit to solve these issues.

This also reduced in half the amount of linting jobs running (later we also could get rid of black in favor of ruff formatter)

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.63%. Comparing base (cde7b9e) to head (7aad8ab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #80 +/- ## ======================================= Coverage 95.62% 95.63% ======================================= Files 17 17 Lines 572 573 +1 ======================================= + Hits 547 548 +1 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.