search

voikko / corevoikko

Libvoikko and essential linguistic resources
Other
89 stars 25 forks source link

Adding apertium Stream Format Support #19

Closed m5w closed 8 years ago

m5w commented 8 years ago

With the --apertium-stream option, voikkospell accepts input and outputs in apertium stream format. Correct words are output as ^surfaceform$, incorrect ones with suggestions as ^_sarfoosfoum/suggestion1/suggestion2$, and incorrect ones without suggestions as ^_sarfoosfoum$. See the wiki page at http://wiki.apertium.org/wiki/Voikkospell.

hatapitk commented 8 years ago

Thanks, looks very good! There is just one thing that would be needed before this can be merged. As this is a substantial contribution the new files should have a header that states the license and copyright holder(s) for the work. The header should look like this: https://github.com/voikko/corevoikko/blob/master/libvoikko/src/tools/voikkospell.cpp#L1-L27 You can just copy and paste this header to each of the new files and replace the name of the initial developer. Also if other developers have participated in developing this they should be named as well and they should state that they agree with having the work covered by MPL/GPL/LGPL license.

It would also be good to check whether Apertium is a good name for the namespace here. Is there a risk of conflicting namespaces if we some day link libvoikko with actual Apertium libraries? Perhaps voikkospell::Apertium would be safer.

hatapitk commented 8 years ago

I'm closing this pull request as inactive, it is unfortunately not possible to merge the code without proper license statements. You are of course welcome to re-open it if the issue can be resolved.