search

voikko / corevoikko

Libvoikko and essential linguistic resources
Other
89 stars 25 forks source link

libvoikko tests not running successfully in pbuilder environment #2

Closed tjyrinki closed 11 years ago

tjyrinki commented 11 years ago

While packaging the new libvoikko 3.6.1 to Debian, I tried enabling tests. It first seemed good, but a test build in pbuilder revealed that the tests failed there for some reason. Attached is the test-suite.log run within pbuilder --login environment manually.

tjyrinki commented 11 years ago 
==========================================
   libvoikko 3.6.1: test/test-suite.log
==========================================

# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: AllAutomaticTests.sh
==========================

...F..F...
======================================================================
FAIL: testDefaultVariantCanBeOpenedWithOldApiUsingValuesSpecifiedInApi (DictionaryInfoTest.DictionaryInfoTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/libvoikko-3.6.1/test/DictionaryInfoTest.py", line 66, in testDefaultVariantCanBeOpenedWithOldApiUsingValuesSpecifiedInApi
    self.assertTrue(self.__tryOpenWithOldApi(u""))
AssertionError: False is not true

======================================================================
FAIL: testVariantCanBeOpenedWithNewApiUsingBCP47LanguageTag (DictionaryInfoTest.DictionaryInfoTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/libvoikko-3.6.1/test/DictionaryInfoTest.py", line 79, in testVariantCanBeOpenedWithNewApiUsingBCP47LanguageTag
    self.assertTrue(self.__tryOpenWithNewApi(u"fi"))
AssertionError: False is not true

----------------------------------------------------------------------
Ran 10 tests in 0.011s

FAILED (failures=2)
tjyrinki commented 11 years ago

A few more tests on Ubuntu side (pbuilder-dist saucy login). Same results in this clean environment.

More precisely, testVariantCanBeOpenedWithNewApiUsingBCP47LanguageTag starts succeeding if I comment the last two tests out (fi and fi-FI). testDefaultVariantCanBeOpenedWithOldApiUsingValuesSpecifiedInApi fails with all the included three inputs.

I don't know what could be different from normal work/distro environment in this kind of clean build environment. I tried locale-gen fi_FI.UTF-8 but it didn't help alone at least.

hatapitk commented 11 years ago

I can reproduce this in a normal environment by renaming /usr/lib/voikko and $HOME/.voikko to something else. So either the setUp method fails to produce suitable dummy dictionaries for the these tests or there is an actual bug in the library. Existence of "real" Finnish dictionary seems to hide these errors. Or it may also be that the expectations made in these two tests are not valid anymore. This test has not been updated in three years. Meanwhile we have slightly changed the semantics of language variant selection to fit the needs of Northern Sami and other languages.

tjyrinki commented 11 years ago

Just confirming that I cherry-picked the fix and it compiled (and ran tests) fine in Debian for all architectures: http://packages.qa.debian.org/libv/libvoikko.html