Closed akx closed 7 years ago
Thank you very much! The changes look good to me (and did not cause any problems after light testing) so I merged them. It is good to keep the external API at least for libvoikko 4.1.1 but in the future we could consider improvements there as well.
Hi (tai terve),
I noticed
libvoikko.py
wasn't exactly Pythonic in style, so I wanted to do something about it.In addition to the style changes (i.e. cleaning up imports, using 4 spaces instead of tabs and rewrapping very long lines, mostly -- use
git diff -w d594bfc
), I also separated the lower-level Voikko CDLL into another object in 265a9fe for ease of use and development.The external API remains the same nevertheless, that is:
camelCase
identifier remaincamelCase
d even ifsnake_case
would be more PythonicVoikko
, it's now easy to replace with another implementation)⚠️ If you think these changes are too radical, I wouldn't be opposed to forking this to a new repository/library, say,
voikko/voikko-py
that I'd be glad to maintain. 😸