search

voikko / corevoikko

Libvoikko and essential linguistic resources
Other
89 stars 25 forks source link

Adapt to the namespace changes in hfst-ospell #34

Closed albbas closed 6 years ago

albbas commented 6 years ago

The namespace in hfst-ospell was changed from hfst_ol to hfst_ospell. This change adapts libvoikko to that change. Checked if the changes worked by building libvoikko and verifying that voikkospell -d se -s works as expected.

Build environment is KDE Neon (based on Ubuntu 16.04) with hfst-ospell from the nightly/unstable apertium.

TinoDidriksen commented 6 years ago

While waiting for merge, I've applied the patch to Apertium's builds.

hatapitk commented 6 years ago

Thanks! The patch looks good but I'll postpone merging it until the change appears in a stable release of hfst-ospell. At that point it will also be possible to update documentation and autoconf tests to require the correct version.

unhammer commented 6 years ago

https://github.com/hfst/hfst-ospell/releases/tag/v0.5.0 released