voila-dashboards / tljh-voila-gallery

Configuration for deploying the Voilà Gallery with The Littlest JupyterHub
BSD 3-Clause "New" or "Revised" License
82 stars 70 forks source link

Add interactive football pitch example #51

Closed seidlr closed 5 years ago

seidlr commented 5 years ago

Added my interactive football pitch voila example.

jtpio commented 5 years ago

Thanks @seidlr, I remember you shared it on Gitter too!

It looks like the repo has both an environment.yml and a requirements.txt files with the same dependencies. Maybe worth only keeping environment.yml to keep things simple and avoid confusion?

jtpio commented 5 years ago

Also we are looking into getting one more change in before adding new examples to the gallery.

seidlr commented 5 years ago

I could delete the file but I think the requirements.txt was needed for heroku deployment. Is it possible to add a reference to a branch in gallery.yaml?

yuvipanda commented 5 years ago

If you have both files, repo2docker will only count the environment.yml file, so I think it's ok...

jtpio commented 5 years ago

Ah ok, then it makes sense to keep both for Heroku.

jtpio commented 5 years ago

Thanks @seidlr!