voila-dashboards / tljh-voila-gallery

Configuration for deploying the Voilà Gallery with The Littlest JupyterHub
BSD 3-Clause "New" or "Revised" License
82 stars 70 forks source link

add 'machine-learning-visualization' to gallery.yaml #67

Closed dhaitz closed 5 years ago

jtpio commented 5 years ago

Thanks @dhaitz!

I think it would also be great to add a Binder badge to the repo. That would point to: https://mybinder.org/v2/gh/dhaitz/machine-learning-interactive-visualization/master?urlpath=voila%2Frender%2Fmachine-learning-interactive-visualization.ipynb

Or to a pinned version: https://mybinder.org/v2/gh/dhaitz/machine-learning-interactive-visualization/0dc76c5647aa2161770a30efd265b1af66254982?urlpath=voila%2Frender%2Fmachine-learning-interactive-visualization.ipynb

Similar to the country-indicator example.

jtpio commented 5 years ago

Also there seems to be an issue with the dependencies when trying it on Binder:

AttributeError: module 'ipywidgets' has no attribute 'GridspecLayout'

It's relevant here because the gallery uses the same tool as Binder for building the example (repo2docker). So we need to tell pip to use ipywidgets 7.5 which adds support for GridspecLayout:

ipywidgets>=7.5,<8
dhaitz commented 5 years ago

Hi @jtpio, thanks for your suggestions! I've updated the requirements, added a binder badge and checked that it works.

jtpio commented 5 years ago

This looks good, thanks @dhaitz!