search

voila-dashboards / tljh-voila-gallery

Configuration for deploying the Voilà Gallery with The Littlest JupyterHub
BSD 3-Clause "New" or "Revised" License
82 stars 70 forks source link

Improve example cards #72

Closed jtpio closed 5 years ago

jtpio commented 5 years ago

As a follow-up for https://github.com/voila-gallery/gallery/pull/70, and suggested by @SylvainCorlay in https://github.com/voila-gallery/gallery/pull/70#issuecomment-535518678, we can do a second pass on the new visual identity:

  • remove the Launch button to make the whole div a launch button (maybe with a transparent > play button on hover)
  • probably remove the Source button to be replaced with a github link in the corner...
SylvainCorlay commented 5 years ago

github

Quick thought on this: maybe another logo than github in case we decide to support gitlab or arbitrary git URLs.

jtpio commented 5 years ago

That should already be supported, since the examples are built with repo2docker (which handles arbitrary git URLs).

jtpio commented 5 years ago

Fixed by https://github.com/voila-gallery/gallery/pull/73